fix: old VMSS AKS cluster cannot be upgraded after April 2 #1561
Conversation
| @@ -688,6 +688,7 @@ func CreateAgentVMSS(cs *api.ContainerService, profile *api.AgentPoolProfile) Vi | |||
| } | |||
|
|
|||
| if cs.Properties.IsHostedMasterProfile() { | |||
| aksBillingExtension.Name = to.StringPtr(fmt.Sprintf("[concat(variables('%sVMNamePrefix'), '-AksLinuxBilling')]", profile.Name)) | |||
There was a problem hiding this comment.
is this going to affect how we track billing data in any way?
Aks should be AKS
What about Windows? This name contains "linux" and will be applied to all extensions, even Windows ones so it might be confusing.
There was a problem hiding this comment.
I see, before the extension name was computeAksLinuxBilling. This might break how we track these extensions if we query by name computeAksLinuxBilling.
There was a problem hiding this comment.
Actually before the extension name was set to [vmssname]-computeLinuxBilling, e.g. aks-nodepool1-40022152-vmss-computeAksLinuxBilling. Don't think this name that varies on different VMSS is used to track billing data.
There was a problem hiding this comment.
good point. @CecileRobertMichon we'd like to get this merged since this broke existing VMSS clusters. If billing tracking is broken, we take the risk.
Codecov Report
@@ Coverage Diff @@
## master #1561 +/- ##
==========================================
+ Coverage 75.86% 75.86% +<.01%
==========================================
Files 128 128
Lines 18314 18316 +2
==========================================
+ Hits 13893 13895 +2
Misses 3636 3636
Partials 785 785 |
|
/hold verifying the impact of the change on the billing tracking |
|
/hold cancel |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon, chengliangli0918 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* old VMSS AKS cluster cannot be upgraded after April 2 * use different extension name for AKS Windows/Linux VMSS * fix unit test
* old VMSS AKS cluster cannot be upgraded after April 2 * use different extension name for AKS Windows/Linux VMSS * fix unit test
Reason for Change:
Old VMSS AKS cluster cannot be upgraded after April 2
AKS-Engine changed AKS billing extension type from Compute.AKS-Engine.Linux.Billing to Compute.AKS.Linux.Billing in this PR (bc462f1). The change was vendored into AKS on Apr. 2nd. So any VMSS cluster created before the change will hit this problem during upgrade. New clusters should be fine.
Issue Fixed:
Rename the billing extension to make the ARM deployment happy
Requirements:
Notes: